Fix redis NOGROUP errors when running samples #429
+24
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the samples that use redis where workers are separate generates non-stop errors like the following: 2025/09/15 23:01:02 ERROR error polling task error="dequeueing task: NOGROUP No such key 'task-stream:system:activities' or consumer group 'task-workers' in XREADGROUP with GROUP option" The original error occurred because: * The worker tries to recover abandoned tasks during startup using XAUTOCLAIM * This requires existing consumer groups for the Redis streams * Previously, consumer groups were only created when PrepareWorkflowQueues/PrepareActivityQueues were explicitly called * The recovery operations happened before queue preparation, causing NOGROUP errors The fix ensures that consumer groups for the essential queues (default and _system_) are created automatically during Redis backend initialization, eliminating the race condition.
cschleiden
force-pushed
the
jwilder/redis-backend
branch
from
c53a377 to
521f2ce
Compare
cschleiden
reviewed
Sep 20, 2025
| // to prevent NOGROUP errors when the worker starts and tries to recover abandoned tasks | ||
| func (rb *redisBackend) ensureDefaultConsumerGroups(ctx context.Context) error { | ||
| // Initialize consumer groups for both default and system queues | ||
| queues := []workflow.Queue{workflow.QueueDefault, core.QueueSystem} |
There was a problem hiding this comment.
Suggested change
| queues := []workflow.Queue{workflow.QueueDefault, core.QueueSystem} | |
| queues := []workflow.Queue{core.QueueDefault, core.QueueSystem} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the samples that use redis where workers are separate generates non-stop errors like the following:
2025/09/15 23:01:02 ERROR error polling task error="dequeueing task: NOGROUP No such key 'task-stream:system:activities' or consumer group 'task-workers' in XREADGROUP with GROUP option"
The original error occurred because:
The fix ensures that consumer groups for the essential queues (default and system) are created automatically during Redis backend initialization, eliminating the race condition.